Pick up latest markdown language service and clean up server package #164516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjbvz
commented
Oct 24, 2022
mjbvz
commented
- Picks up newest markdown language service
- Excludes some files from server publish
- Delete unused file
- Update readme
- Align server version with LS version
- Picks up newest markdown language service - Excludes some files from server publish - Delete unused file - Update readme - Align server version with LS version
rebornix
approved these changes
Oct 24, 2022
rzhao271
approved these changes
Oct 24, 2022
|
|
||
| - [Smart selection](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_selectionRange) for inline elements, block elements, and header sections. | ||
|
|
||
| - [Document Symbols](https://microsoft.github.io/language-server-protocol/specification#textDocument_documentSymbol) for quick navigation to headers in a document. |
There was a problem hiding this comment.
Nit: casing on this link text is inconsistent with other links
|
|
||
| The source code of the Markdown language server can be found in the [VSCode repository](https://github.com/microsoft/vscode) at [extensions/markdown-language-features/server](https://github.com/microsoft/vscode/tree/master/extensions/markdown-language-features/server). | ||
|
|
||
| File issues and pull requests in the [VSCode GitHub Issues](https://github.com/microsoft/vscode/issues). See the document [How to Contribute](https://github.com/microsoft/vscode/wiki/How-to-Contribute) on how to build and run from source. |
There was a problem hiding this comment.
Nit: "VSCode GitHub issues tracker" or remove "the" in front of the link text
| @@ -0,0 +1,135 @@ | |||
| # Markdown Language Server | |||
|
|
|||
| > **❗ Import** This is still in development. While the language server is being used by VS Code, it has not yet been tested with other clients. | |||
There was a problem hiding this comment.
Nit: Important instead of import
formigoni
pushed a commit
to formigoni/vscode
that referenced
this pull request
Oct 27, 2022
…icrosoft#164516) - Picks up newest markdown language service - Excludes some files from server publish - Delete unused file - Update readme - Align server version with LS version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.